[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [7234] Use a more natural order
From: |
M. Warner Losh |
Subject: |
Re: [Qemu-devel] [7234] Use a more natural order |
Date: |
Thu, 23 Apr 2009 13:12:50 -0600 (MDT) |
In message: <address@hidden>
address@hidden (Lennart Sorensen) writes:
: On Thu, Apr 23, 2009 at 06:29:47PM +0000, Blue Swirl wrote:
: > Revision: 7234
: > http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7234
: > Author: blueswir1
: > Date: 2009-04-23 18:29:47 +0000 (Thu, 23 Apr 2009)
: > Log Message:
: > -----------
: > Use a more natural order
:
: It may be more natural, but it is also less safe.
:
: After all
:
: if (0 = x) {
:
: fails compile, while
:
: if (x = 0) {
:
: compiles silently even when you didn't mean that.
This style is evil and must die. I don't know any nice way to put
it. It encourages sloppiness. Also, it breaks down when you add
inequality:
if (x < 1)
becomes
if (1 >= x)
which is also error prone.
The compiler will warn about your example, but won't warn if I
transcribe things wrongly as
if (1 < x)
: Some people also think month/day/year is more natural as a date format,
: but it is confusing and impractical to actually use.
True, but irrelevant.
Warner
- Re: [Qemu-devel] [7234] Use a more natural order, (continued)
- Re: [Qemu-devel] [7234] Use a more natural order, Gerd Hoffmann, 2009/04/24
- Re: [Qemu-devel] [7234] Use a more natural order, Anthony Liguori, 2009/04/24
- Re: [Qemu-devel] [7234] Use a more natural order, Stefan Weil, 2009/04/24
- Re: [Qemu-devel] [7234] Use a more natural order, Blue Swirl, 2009/04/23
- Re: [Qemu-devel] [7234] Use a more natural order, Lennart Sorensen, 2009/04/23
- Re: [Qemu-devel] [7234] Use a more natural order, Jamie Lokier, 2009/04/23
- Re: [Qemu-devel] [7234] Use a more natural order, Lennart Sorensen, 2009/04/24
- Re: [Qemu-devel] [7234] Use a more natural order, Nathan Froyd, 2009/04/24
Re: [Qemu-devel] [7234] Use a more natural order,
M. Warner Losh <=
- Re: [Qemu-devel] [7234] Use a more natural order, Lennart Sorensen, 2009/04/23
- Re: [Qemu-devel] [7234] Use a more natural order, M. Warner Losh, 2009/04/23
- Re: [Qemu-devel] [7234] Use a more natural order, Lennart Sorensen, 2009/04/23
- Re: [Qemu-devel] [7234] Use a more natural order, M. Warner Losh, 2009/04/23
- Re: [Qemu-devel] [7234] Use a more natural order, Lennart Sorensen, 2009/04/23
Re: [Qemu-devel] [7234] Use a more natural order, Jamie Lokier, 2009/04/23
Re: [Qemu-devel] [7234] Use a more natural order, Jamie Lokier, 2009/04/23
[Qemu-devel] Re: [7234] Use a more natural order, Jan Kiszka, 2009/04/23