qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2


From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] qcow2 corruption: Fix alloc_cluster_link_l2
Date: Sun, 26 Apr 2009 17:14:03 +0300
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Christoph Hellwig wrote:
Maybe it's time to make use of sparse's endianess annotations in qcow2
to prevent further problems like this one

I'd much prefer strong type checking at compile time:

   typedef struct le32 {
       uint32_t blah;
   } le32;

   static inline le32 cpu_to_le32(uint32_t blah) { ... }
   static inline uint32_t le32_to_cpu(le32 blah) { ... }

--
error compiling committee.c: too many arguments to function





reply via email to

[Prev in Thread] Current Thread [Next in Thread]