|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH v2] kvm: Avoid COW if KVM MMU is asynchronous |
Date: | Sun, 26 Apr 2009 19:21:21 +0300 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Jan Kiszka wrote:
If the KVM MMU is asynchronous (kernel does not support MMU_NOTIFIER), we have to avoid COW for the guest memory. Otherwise we risk serious breakage when guest pages change there physical locations due to COW after fork. Seen when forking smbd during runtime via -smb.last_ram_offset += size; + if (kvm_enabled())+ kvm_setup_guest_memory(new_block->host, size); + return new_block->offset; }
I feel a little bad about picking such small nits, but the if statement requires braces.
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |