Re: [Qemu-devel] [PATCH] linux-user: Added IP_ADD_MEMBERSHIP/IP_DROP_MEMBERSHIP flags to setsockopt

[Jamie Lokier]

Riku Voipio wrote:
> On Wed, Apr 29, 2009 at 10:00:18PM +0100, Jamie Lokier wrote:
> > Riku Voipio wrote:
> > > On Wed, Apr 29, 2009 at 09:35:52PM +0100, Jamie Lokier wrote:
> > > > Riku Voipio wrote:
> > > > > These are defined in include/linux/in.h so they should be same on all 
> > > > > archs?
> > > 
> > > > But what if you're compiling for a non-Linux host?
> > > 
> > > Generally speaking if you comple Qemu Linux-user on a non-Linux host you
> > > just fail. With or without this patch.
> 
> > Oh.  Are non-Linux hosts officially not supported, or is this just a
> > matter of some things being broken?
> 
> It is not officially supported. There are just too many places in the
> current linux-user code that expect a linux host. Thou there has been
> interest in working those bits to be more generic recently. recently.

If there's real interest in working those bits for other hosts,
*new* bits should use TARGET_ constants to avoid making life even
harder when it comes to finding places where'll they need to be
changed to TARGET_ later.

-- Jamie