Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3

[Anthony Liguori]

David Ahern wrote:
> Missed that. Forgot to add net.h to vnc.c.
>
> Before I re-send a patch, what's the feeling regarding enabling this all
> the time versus a command line option to control it?
>
> david
>   

I'm on the fence.  It's not something I think is extremely common and it 
seems like we're going to great lengths to fix up one persons broken 
configuration.

However, it really doesn't do any harm and I can understand the argument 
for it.  So far, I haven't seen anyone raise an issue with why this 
would not be a reasonable thing to do.

FWIW, in my opinion, it's an all or nothing thing.  It's not a knob I 
think we ought to be exposing.

--
Regards,

Anthony Liguori