qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] 64 bit I/O support v7


From: Paul Brook
Subject: Re: [Qemu-devel] [PATCH] 64 bit I/O support v7
Date: Sat, 2 May 2009 01:40:46 +0100
User-agent: KMail/1.9.9

> > My guess is that in pactice we only have certain SPARC devices that need
> > to trap when you do a wrong sized access, and for everything else you're
> > told not to do that, and qemu can happily return garbage.
> >
> > If this is the case then the IO_MEM_SUBWIDTH code seems like complete
> > overkill. I reccommend ripping it out, and maybe having the registration
> > function replace NULL with the unassigned hander.
>
> Wouldn't making a version of the subpage structure the default
> and getting rid of the multiple parallel arrays make more sense.
> Then there would only be one type of I/O memory and no special
> cases.

I'm not sure what you're suggesting. I've yet to see any actual use of the 
subwidth code, and the subpage stuff is fairly rare. 

Trying to push the subpage code down into the TLB handler might be possible, 
but you'd have to be careful to avoid performance regressions in the common 
code.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]