[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migratio
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration |
Date: |
Sun, 3 May 2009 09:05:02 +0300 |
On Sun, May 03, 2009 at 08:57:58AM +0300, Avi Kivity wrote:
> Gleb Natapov wrote:
>> On Sat, May 02, 2009 at 10:12:57PM +0300, Avi Kivity wrote:
>>
>>> Gleb Natapov wrote:
>>>
>>>>> I think the right thing to do with this is introduce a kvm-cpu
>>>>> savevm that stores this information since it isn't relevant to
>>>>> TCG. I think it's arguable whether you want instruction length
>>>>> there (can you get it reliably on SVM?).
>>>>>
>>>>>
>>>> We can't get it on SVM without instruction decoding, but it is not required
>>>> on SVM. It is absolutely essential for soft interrupt/exception injection
>>>> on VMX and has to be a part of migratable state.
>>>>
>>> We need it in some neutral form so cross-vendor migration can work.
>>>
>>>
>> VMX->SVM No problem.
>> SVM->VMX bad luck :) We will have to decode instruction ourself.
>
> I don't think it's necessary. We can record the software interrupt at
> the end of the instruction that generated it, and give it higher
> priority than a pending external interrupt. On vmx, decrement RIP and
> set entry instruction length = 1 before injection.
And get wrong error value when exception happens during soft interrupt
delivery? I don't like all those tricks. They work only if everything
happens like you expected and breaks completely when it is not.
> On svm, use EVENTINJ
> and forget about the instruction length.
>
On SVM we do not re-inject soft int/exception at all, but re-execute the
offending instruction.
--
Gleb.
- [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, (continued)
- [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Jan Kiszka, 2009/05/01
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Gleb Natapov, 2009/05/02
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Anthony Liguori, 2009/05/02
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Gleb Natapov, 2009/05/02
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Avi Kivity, 2009/05/02
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Gleb Natapov, 2009/05/02
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and livemigration, Anthony Liguori, 2009/05/02
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and livemigration, Gleb Natapov, 2009/05/03
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Avi Kivity, 2009/05/03
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration,
Gleb Natapov <=
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Avi Kivity, 2009/05/03
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Gleb Natapov, 2009/05/03
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Avi Kivity, 2009/05/03
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Gleb Natapov, 2009/05/03
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Avi Kivity, 2009/05/03
- Re: [Qemu-devel] Re: [PATCH 0/8] kvm: Fixes, cleanups and live migration, Gleb Natapov, 2009/05/03
[Qemu-devel] [PATCH 9/8] kvm: Save/restore TSC counter, Jan Kiszka, 2009/05/01