Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2

[Alexander Graf]

On 06.05.2009, at 16:39, Anthony Liguori wrote:

> Kevin Wolf wrote:
> > Anthony Liguori schrieb:
> >
> > > I've changed my mind.  I think file: makes the situation worse  
> > > because it gives a false sense of security.  If you just pass  
> > > file:<user-inputed-filename> you are broken.  You still have to  
> > > escape commas.  If you're escaping commas, you might as well  
> > > escape colons too.
> > >
> > > I think escaping is the only complete solution.
> >
> > You're completely right if we don't limit the discussion to colons.  
> > I'm
> > not sure if breaking colons really makes tools aware that they need  
> > to
> > take care of commas, but "it's broken anyway" is a reasonable  
> > answer if
> > we can have a generic fix (and we can have it here).
>
> If we have escaping, I'm happy to consider file: if people still  
> think it's useful.  But adding file: without escaping is IMHO  
> dangerous.
>
> > So what should the generic escaping look like?
>
> -drive file=my-silly\:filename\,with\ strange\ characters

I liked the idea of URI escaping, like "%20" being byte 32 -> space.  
There are enough libraries out there that can easily generate such an  
escaping, so people don't have to stick with a dozen of different ways  
of escaping, depending on which option they're using.

Alex