Re: [Qemu-devel] [PATCH 1/4] move registering of cpu_reset to inside cpu_init

[Glauber Costa]

On Wed, May 06, 2009 at 10:36:16PM +0300, Blue Swirl wrote:
> On 5/6/09, Glauber Costa <address@hidden> wrote:
> > This is not pc specific by any means. So we can be
> >  moved to inside cpu_x86_init().
> >
> >  This is part of an attempt to only initialize kvm state
> >  after everything is already properly initialized. If we don't
> >  do that, we can race against, for example, APIC state if kvm vcpus
> >  are ran in threads (happens in qemu-kvm.git, soon to happen here too)
> 
> I'd move this too to exec.c. Sparc registers two reset functions, the
> first one for the main cpu disables halted state, the second one for
> non-boot cpus halts them on reset. I wonder why i386 does not do the
> same.

Probably because we were halting the cpu separatedly.
Btw, after looking again, cpu_reset looks like an even better place
to hold the halted change.