[Qemu-devel] Re: pci_default_config_write() clean up.

[Michael S. Tsirkin]

On Thu, May 07, 2009 at 06:06:39PM +0900, Isaku Yamahata wrote:
> On Thu, May 07, 2009 at 11:50:10AM +0300, Michael S. Tsirkin wrote:
> > Hmm, this adds more code that it removes.
> > Did you take a look at my attempt at the rewrite of the same function?
> 
> Yes, so I added you on Cc.
> The most of code is trivial tables,
> so I don't think it complicates the logic.

Well, one still needs to wade through them to figure out
how things work.

> If we want more precise emulation, your pci_init_mask()
> will bigger anyway.

The diffstat for both patches tells a different story :)

-- 
MST