[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: pci_default_config_write() clean up.
From: |
Isaku Yamahata |
Subject: |
Re: [Qemu-devel] Re: pci_default_config_write() clean up. |
Date: |
Thu, 7 May 2009 20:13:51 +0900 |
User-agent: |
Mutt/1.5.6i |
On Thu, May 07, 2009 at 01:25:38PM +0300, Michael S. Tsirkin wrote:
> > How about callback?
>
> Yes, I think callbacks have the potential to simplify code.
> Would you like to add them on top of my patch then?
Okay.
> - There's some tricky code there to trigger callbacks only once
> on a multibyte transaction. It would be simpler just to have per-dword
> callbacks. These could get the mask of the written-to bytes and do
> if (written_mask & interesting_mask)
> stuff
Are you assuming that word/dword io port access is word/dword aligned?
--
yamahata