[Qemu-devel] Re: [Qemu-commits] [COMMIT b864a57] Fixe ARM NEON vrshl.

[Laurent Desnogues]

On Sun, May 10, 2009 at 12:14 AM, Anthony Liguori <address@hidden> wrote:
> From: Paul Brook <address@hidden>
>
> Signed-off-by: Paul Brook <address@hidden>
>
> diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
> index 4ee5658..35fbaf5 100644
> --- a/target-arm/neon_helper.c
> +++ b/target-arm/neon_helper.c
> @@ -456,11 +456,11 @@ uint64_t HELPER(neon_shl_s64)(uint64_t valop, uint64_t 
> shiftop)
>     if (tmp >= sizeof(src1) * 8) { \
>         dest = 0; \
>     } else if (tmp < -sizeof(src1) * 8) { \
> -        dest >>= sizeof(src1) * 8 - 1; \
> +        dest = src1 >> (sizeof(src1) * 8 - 1); \
>     } else if (tmp == -sizeof(src1) * 8) { \
>         dest = src1 >> (tmp - 1); \

Isn't that a right shift by a negative amount?


Laurent

>         dest++; \
> -        src2 >>= 1; \
> +        dest >>= 1; \
>     } else if (tmp < 0) { \
>         dest = (src1 + (1 << (-1 - tmp))) >> -tmp; \
>     } else { \