Re: [Qemu-devel] [PATCH] suppress 'warn_unused_result' warning

[Stuart Brady]

On Mon, May 11, 2009 at 03:15:11AM +0800, Chih-Min Chao wrote:
> The patch add error handling to functions with 'warn_unused_result' return
> value such as write, read, ftruncate, and realpath.

I'm slightly concerned -- read(), write() and ftruncate() can fail with
EINTR if a signal is received at an unfortunate time, can't they?

Do we mitigate this for the most part, somehow?

Do kernels try to avoid this behaviour?  If so, under what circumstances
might EINTR still be returned?

Is it acceptable to have a wrapper around these functions that retries
if the call fails with EINTR?

I would guess that for the most part, getting EINTR back is pretty rare,
as there's an awful lot of code (in QEMU and in other projects) that
doesn't check for it.

BTW, is it be possible for the write in qemu_event_increment() to
io_thread_fd to fail with EAGAIN?  If so, aborting with perror()
probably isn't right.
-- 
Stuart Brady