Re: [Qemu-devel] Re: [PATCH 2/4] qemu: make default_write_config use mask table

[Michael S. Tsirkin]

On Wed, May 13, 2009 at 05:27:46PM +0900, Isaku Yamahata wrote:
> On Wed, May 13, 2009 at 11:07:24AM +0300, Michael S. Tsirkin wrote:
> > On Wed, May 13, 2009 at 04:50:50PM +0900, Isaku Yamahata wrote:
> > > Change much of hw/pci to use symbolic constants and a table-driven
> > > design: add a mask table with writable bits set and readonly bits unset.
> > > Detect change by comparing original and new registers.
> > > 
> > > As a result, writing a single byte in BAR registers now works as it
> > > should. Writing to upper limit registers in the bridge also works as it
> > > should. Writes to BAR registers trigger mapping update.  Code is also
> > > shorter.
> > > 
> > > Changelog since v1
> > > - simplify the code some more
> > > - use PCI_CONFIG_SPACE_SIZE instead of 0x100
> > > - only trigger pci update when IO/MEM bits in command register have 
> > > changed
> > > 
> > > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > 
> > You must also add
> > From: Michael S. Tsirkin <address@hidden>
> > 
> > at the top, otherwise git won't record the authorship
> > information in log correctly.
> 
> Oh sorry, does this looks okay?
> 
> From: Michael S. Tsirkin <address@hidden>
> 
> Change much of hw/pci to use symbolic constants and a table-driven
> design: add a mask table with writable bits set and readonly bits unset.
> Detect change by comparing original and new registers.
> 
> As a result, writing a single byte in BAR registers now works as it
> should. Writing to upper limit registers in the bridge also works as it
> should. Writes to BAR registers trigger mapping update.  Code is also
> shorter.
> 
> Changelog since v1
> - simplify the code some more
> - use PCI_CONFIG_SPACE_SIZE instead of 0x100
> - only trigger pci update when IO/MEM bits in command register have changed
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  hw/pci.c |  147 
> +++++++++++++-------------------------------------------------
>  hw/pci.h |   18 +++++++-
>  2 files changed, 47 insertions(+), 118 deletions(-)
> 

Right. But Changelog should come after ---: you want git to ignore it.

-- 
MST