Re: [Qemu-devel] [PATCH 0/3] linux-user: add ppc signal handling, v2

[malc]

On Tue, 12 May 2009, Nathan Froyd wrote:

> On Wed, May 13, 2009 at 03:13:10AM +0400, malc wrote:
> > On Tue, 12 May 2009, Nathan Froyd wrote:
> > > This patch series adds signal handling support for 32-bit PPC linux-user
> > > emulation.  It requires a bit of shuffling of target-ppc code to ensure
> > > that we know what the capabilities of our current CPU are so we know
> > > which registers to save.
> > 
> > This one works as is, however the series introduces 3 instances of
> > trailing whitespace (git complains) and few new tab characters (my
> > eyes do).
> 
> Sorry about that; fixed in a reply to part 2/3 of the patch series.
> 
> > Plus while building it (this time with gcc 3.4.6) i noticed
> > that the warnings around __put_user are gone, but lines 2746 and 2747
> > of op_helper.c produce (both originate from d9430add, which is also
> > yours):
> > 
> > warning: array subscript is above array bounds
> > 
> > Boils down to:
> > 
> > #define VSHIFT(suffix, leftp)                                           \
> >     void helper_vs##suffix (ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b)   \
> >     {                                                                   \
> >         int shift = b->u8[LO_IDX*0x15] & 0x7;                           \
> > 
> > I'd venture a guess that '*15' instead was meant to be there.
> 
> Indeed.  I will fix this in a separate patch unless you beat me to
> it. :)  Thanks for the heads-up.

Done. BTW. here's another:

target-ppc/op_helper.c:1977: warning: comparison is always false due to 
limited range of data type

This one is probably harmless, but still.. [The code is due to Aurelien
this time around though]

-- 
mailto:address@hidden