qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [RFC][PATCH 0/3] Make qemu-img create options generic


From: Kevin Wolf
Subject: [Qemu-devel] [RFC][PATCH 0/3] Make qemu-img create options generic
Date: Thu, 14 May 2009 16:12:01 +0200

Currently, qemu-img and the bdrv_create() interface need to carry parameters
for every single option that is used by at least one file format. We already
have a few of such format specific options (encryption for qcow2, version 6
header for VMDK, backing file for some formats) and there are more to come
(like qcow cluster size).

This patch series changes this into a more generic approach: All block drivers
contain a data structure which describes all options this driver recognizes.
qemu-img can use this structure then instead of hard-coding every single
option. An -o option is introduced for these parameteres, the format is the
usual comma separated name=value style as in -drive.

This series is not yet meant to be applied. qemu-img convert still needs to be
converted to the new interface and it's not exactly tested extensively (let
alone the state after patch 1 or 2 applied without the rest). Maybe it also
could use some better identifiers, I'm open for suggestions.

Kevin Wolf (3):
  Create qemu-option.h
  Convert all block drivers
  Convert qemu-img create

 Makefile          |    2 +-
 block-cow.c       |   24 ++++-
 block-qcow.c      |   28 +++++-
 block-qcow2.c     |   36 ++++++-
 block-raw-posix.c |   37 +++++--
 block-raw-win32.c |   20 +++-
 block-vmdk.c      |   28 +++++-
 block-vpc.c       |   21 +++-
 block-vvfat.c     |    4 +-
 block.c           |   44 ++++++--
 block.h           |    6 +-
 block_int.h       |   17 ++-
 qemu-img.c        |  133 +++++++++++++++++---------
 qemu-option.c     |  280 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 qemu-option.h     |   61 ++++++++++++
 sysemu.h          |    2 -
 vl.c              |   38 +-------
 17 files changed, 642 insertions(+), 139 deletions(-)
 create mode 100644 qemu-option.c
 create mode 100644 qemu-option.h





reply via email to

[Prev in Thread] Current Thread [Next in Thread]