Re: [Qemu-devel] [PATCH] Revived GUEST_BASE support for usermode emulation targets [v4]

[Martin Mohring]

Riku Voipio wrote:
> On Fri, May 15, 2009 at 03:25:31AM +0100, Paul Brook wrote:
>   
>> On Tuesday 05 May 2009, Riku Voipio wrote:
>>     
>>> On Tue, May 05, 2009 at 10:02:41PM +0400, malc wrote:
>>>       
>>>> Things should work the way they are in your latest patch on x86 and
>>>> should be done the way it's done in the original submission (mov + add)
>>>> for x86_64.
>>>>         
>
>   
>>> Ok.. here we go. not on a amd64 machine right now so I will test
>>> that part tomorrow.
>>>       
>
>   
>> I'm pretty sure it's still broken for large offsets.
>>     
>
> It is indeed broken. Since tcg_out_addi maps on x86_64 to tgen_arithi64 which
> doesn't accept 64bit values. But as Martin said, the currrent use for this
> patch is just to add very minimal offsets.
>
> Martin, I just rebased the linux-user patches, they should apply again
> (there was only a conflict in configure):
>   
Sorted this out already by myself, tnx though.

Since i am using guest base, what does its brokenness mean? Riku, will
you talk with the author to fix it according to Pauls suggestions? Or
will the patch be accepted under the assumptions/constraints it was
written. Or is the request that a generic solution fixes other
longstanding issues?

Martin