Re: [Qemu-devel] [PATCH] qemu: cleanup default_write_config

[Michael S. Tsirkin]

On Mon, May 04, 2009 at 01:01:22AM +0300, Michael S. Tsirkin wrote:
> Change pci default write config to use symbolic constants and a table-driven
> design: add a mask table with writable bits set and readonly bits unset.
> This makes it much easier to support multi-byte registers.
> 
> As a result, writing a single byte in BAR registers now works as
> it should. Writing to upper limit registers in the bridge
> also works as it should. Code is also shorter.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>

Any feedback on this patch?
I'd like to use mask table as the basis for MSI integration work (setting
up appropriate masks for capability bits) and if there are issues with
this approach, I'd like to know.


-- 
MST