Re: [Qemu-devel] [PATCH ] linux-user: add tee systemcall support

[Riku Voipio]

On Tue, May 19, 2009 at 01:42:03PM +0530, vibi sreenivasan wrote:
> hi all,

> >Subject: [Qemu-devel] [PATCH ] linux-user: add tee systemcall support

> Is there any thing wrong with this patch. Please give some feedback
> So if there is anything wrong i will be able to correct it.

The implementation of tee appears fine. However, the tee testcases
I found all also used splice. What did you use to test this, or do
you plan to implement splice too?

> 
> Thanks & Regards
> vibi sreenivasan
> 
> >Signed-off-by: vibi <address@hidden>
> >---
> >linux-user/syscall.c |    8 ++++++++
> >1 files changed, 8 insertions(+), 0 deletions(-)
> 
> >diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> >index 76f0c95..f2f87c3 100644
> >--- a/linux-user/syscall.c
> >+++ b/linux-user/syscall.c
> >@@ -6580,6 +6580,14 @@ abi_long do_syscall(void *cpu_env, int num,
> >abi_long arg1,
>          break;
> >#endif
>  
> >+#ifdef TARGET_NR_tee
> >+    case TARGET_NR_tee:
> >+        {
> >+            ret = get_errno(tee(arg1,arg2,arg3,arg4));
> >+        }
> >+        break;
> >+#endif
> >+
> >     default:
> >     unimplemented:
> >         gemu_log("qemu: Unsupported syscall: %d\n", num);
> 
> 
> 
>