[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH STABLE 2/2] net: Fix -net socket parameter check
|
From: |
Jan Kiszka |
|
Subject: |
[Qemu-devel] Re: [PATCH STABLE 2/2] net: Fix -net socket parameter checks |
|
Date: |
Thu, 21 May 2009 08:23:22 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Glauber Costa wrote:
> My commit ea053add700d8abe203cd79a9ffb082aee4eabc0 broke -net socket by
> overwriting an intermediate buffer in the added check_param. Fix this
> by switching check_param to automatic buffer allocation and release, ie.
> callers no longer have to worry about providing a scratch buffer.
That commit was buggy, too, and is awaiting to be fixed in unstable by
http://permalink.gmane.org/gmane.comp.emulators.qemu/43041.
But more importantly, it makes no sense in stable because its "heart",
param checking for -net is only in unstable (and that's perfectly fine).
Jan
signature.asc
Description: OpenPGP digital signature