Re: [Qemu-devel] [PATCH] augment info migrate with page status

[Daniel P. Berrange]

On Thu, May 21, 2009 at 05:58:10PM +0300, Avi Kivity wrote:
> Daniel P. Berrange wrote:
> >On Wed, May 20, 2009 at 07:20:05PM -0400, Glauber Costa wrote:
> >  
> >>This patch augments info migrate output with status about:
> >>* pages remaining
> >>* pages transferred
> >>    
> >
> >Could you add 'pages total' and/or possibly 'page size', so apps 
> >using this can more easily do calculations, without having to worry
> >about hardcoding page sizes for each architecture they deal with. 
> >
> >Oh, what happens if the guest is backed by huge pages ? Does the
> >'pages transferred' always count in terms of 4k pages, even if
> >2 M & 1 GB pages are in use ?
> >  
> 
> We should just use bytes.  I don't see how backing page size matters.

That works for me, because ultimately bytes is what I'd want at libvirt
layer. 

Regards,
Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|