Re: [Qemu-devel] Windows runtime error

[Blue Swirl]

On 5/22/09, Anthony Liguori <address@hidden> wrote:
> Blue Swirl wrote:
>
> > On 5/22/09, Anthony Liguori <address@hidden> wrote:
> >
> >
> > > Consul wrote:
> > >
> > >
> > >
> > > > This commit breaks Windows giving runtime error "Unknown device
> > > >
> > > >
> > > 'virtio-balloon-pci'"
> > >
> > >
> > > > ec6bd8dea77478f32981a5df49f66ca2430ad19d
> > > >
> > > > Author: Blue Swirl <address@hidden>  2009-05-21 11:22:59
> > > > Committer: Blue Swirl <address@hidden>  2009-05-21 11:22:59
> > > > Parent: 2567f5796c38238d6f2055f074e347a0338140ce
> (Compile
> > > >
> > > >
> > > most Xen files only once)
> > >
> > >
> > > >   Fix arm-softmmu breakage
> > > >
> > > >   Don't use whole-archive for hwlib or libqemu objects
> > > >
> > > >   Signed-off-by: Blue Swirl <address@hidden>
> > > >
> > > >
> > > >
> > >  hwlib definitely needs whole-archive.
> > >
> > >
> >
> > No, it works fine without it.
> >
> >
>
>  virtio-pci has a constructor and all static functions.  It'll be removed
> from the archive without whole-archive.  This is failure that we're seeing.

Oh, I see now! Sorry for the noise.

>  In general, hwlib will need whole-archive because hwlib will contain things
> with constructors.

Right.

> >
> > >  Why did this break arm-softmmu?  It builds fine for me.
> > >
> > >
> >
> > Because fdc.o was forced to be linked in with whole-archive but the
> > stuff that it depends on may be undefined on ARM. With whole-archive
> > removed from hwlib, fdc.o is not referenced in anywhere in arm-softmmu
> > and it will not be pulled in.
> >
> >
>  fdc.o shouldn't be in hwlib if it depends on stuff not defined in a
> particular architecture.

It would be nice to avoid this restriction. For example, fdc init
could take pointers to the DMA functions as parameters.