[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers
From: |
Vincent Sanders |
Subject: |
Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers |
Date: |
Sat, 23 May 2009 17:50:33 +0100 |
User-agent: |
Mutt/1.5.17+20080114 (2008-01-14) |
On Thu, Apr 30, 2009 at 05:08:01PM +0100, Paul Brook wrote:
> > env->cp15.c0_cpuid = id;
> > switch (id) {
> > + case ARM_CPUID_ARM920T:
> > + break;
>
> This is woefully incomplete. At minimum it needs a comment describing how
> this
> is a lie.
I have worked out what you meant was that the copro 15 registers
needed configuring appropriately in this case. This I have done and
the new series, integrating others feedback, has been posted. This is
against the git server as of a few minutes ago.
I would be grateful if you would at least consider this series for
merging. If it is not yet suitable could you please provide some
constructive explanation as to what further changes are required? At
the very least the core ARM920T patch could be merged without much
controversy?
The series has been presented several times over a number of years
always incorporating all feedback given. Despite this little progress
seems to have been made and I am beginning to wonder if there is any
point in continuing?
--
Regards Vincent
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers,
Vincent Sanders <=
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Paul Brook, 2009/05/24
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Vincent Sanders, 2009/05/26
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Laurent Desnogues, 2009/05/26
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Jamie Lokier, 2009/05/26
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Laurent Desnogues, 2009/05/26
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Jamie Lokier, 2009/05/26
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Laurent Desnogues, 2009/05/26
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Paul Brook, 2009/05/26
- Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers, Vincent Sanders, 2009/05/26