Re: [Qemu-devel] [PATCH 1/2] add non-arbitrary migration stop condition

[Avi Kivity]

Anthony Liguori wrote:
> Glauber Costa wrote:
> > Signed-off-by: Glauber Costa <address@hidden>
> > ---
> >  migration.c |    7 +++++++
> >  migration.h |    2 ++
> >  vl.c        |   14 ++++++++++++--
> >  3 files changed, 21 insertions(+), 2 deletions(-)
> >
> > diff --git a/migration.c b/migration.c
> > index 401383c..4036e64 100644
> > --- a/migration.c
> > +++ b/migration.c
> > @@ -107,6 +107,13 @@ void do_migrate_set_speed(Monitor *mon, const 
> > char *value)
> >       }
> >  
> > +static int64_t max_downtime = 30000000;
> >   
>
> In units of..?  Wouldn't it make sense to store this in milliseconds 
> or microseconds as opposed to nanoseconds?

qemu time is in nanoseconds, IIRC.  User visible quantities should be in 
seconds.



--
error compiling committee.c: too many arguments to function