Re: [Qemu-devel] [PATCH 1/16] ARM Add ARM 920T identifiers

[Paul Brook]

On Saturday 23 May 2009, Vincent Sanders wrote:
> On Thu, Apr 30, 2009 at 05:08:01PM +0100, Paul Brook wrote:
> > >      env->cp15.c0_cpuid = id;
> > >      switch (id) {
> > > +    case ARM_CPUID_ARM920T:
> > > +       break;
> >
> > This is woefully incomplete. At minimum it needs a comment describing how
> > this is a lie.
>
> I have worked out what you meant was that the copro 15 registers
> needed configuring appropriately in this case.

More fundamental than that. We emulate armv5te. The arm920t is armv4t.
i.e. even usermode code may not work right.

Paul