|
From: | Dor Laor |
Subject: | Re: autotest (was Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT f80f9ec] Convert machine registration to use module initfunctions) |
Date: | Tue, 26 May 2009 12:17:56 +0300 |
User-agent: | Thunderbird 2.0.0.19 (X11/20090105) |
Anthony Liguori wrote:
Current kvm autotest do test slirp. The step-files for guest installation open ssh/telnet access in orderAvi Kivity wrote:Anthony Liguori wrote:Autotest doesn't currently test the regressions that I want to test.Which regressions do you want to test?For instance, we often have networking regressions. In particular, with the refactoring going on in slirp and tun/tap, I'd really like to have an automated way to test slirp and tap with TCP transmit/receive, and slirp redir. I have something locally to do this that I intend on posting in the next few days.
to let the host reach them. We trapped exactly this regression using autotest.
Some features are easily tested using a large framework, for example migration, slirp, time drift, etc. In addition kvm's tests unit tests, qemu-io and similar should be written too in order to test various cases thatOne way to increase coverage is to require each patch (fix or feature) to come with a test. On the other hand, it might stop contributions instead of increasing test coverage.I've used this method for the x86 emulator in kvm, with some success.I wouldn't require kvm-autotest, but I'd like to have an interest set of unit tests that are then usable within kvm-autotest. Once we have that, asking politely for tests to be written I think is quite reasonable.
are only reasonable to be found using low level operations. No doubt all of the unit tests should be executed from autotest.
Regards, Anthony Liguori
[Prev in Thread] | Current Thread | [Next in Thread] |