[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] Add serial number support for virtio_blk, V
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] Add serial number support for virtio_blk, V3 |
|
Date: |
Wed, 27 May 2009 09:51:33 +0200 |
|
User-agent: |
Mutt/1.3.28i |
Looks good to me. In a couple of places you have spaces beforing
the opening brace as in:
+ memcpy(&blkcfg.serial, s->serial_str, sizeof (blkcfg.serial));
which is not the style used in the surrounding code, I'd suggest
removing them.