Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3

[Rusty Russell]

On Wed, 27 May 2009 05:19:19 pm Christoph Hellwig wrote:
> You should probably include rusty as he's collecting the patches
> for the virtio guest drivers.

Yes.  It *does* help to cc the maintainer if you want your patches applied :)

And I particularly love untested code like this!

> +     if (!(id = kzalloc(ATA_ID_WORDS, GFP_KERNEL)))
> +             rv = -ENOMEM;

Doesn't ATA_ID_WORDS seem like a strange name for a number of bytes?

What's this *for* BTW?
Rusty.