[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/11] slirp: Rework external configuration inte
From: |
Mark McLoughlin |
Subject: |
Re: [Qemu-devel] [PATCH 10/11] slirp: Rework external configuration interface |
Date: |
Thu, 28 May 2009 16:07:27 +0100 |
On Fri, 2009-05-08 at 12:34 +0200, Jan Kiszka wrote:
> With the internal IP configuration made more flexible, we can now
> enhance the user interface. This patch adds a number of new options to
> "-net user": net (address and mask), host, dhcpstart, dns and smbserver.
> It also renames "redir" to "hostfwd" and "channel" to "guestfwd" in
> order to (hopefully) clarify their meanings. The format of guestfwd is
> extended so that the user can define not only the port but also the
> virtual server's IP address the forwarding starts from.
>
> Signed-off-by: Jan Kiszka <address@hidden>
...
> @@ -1988,15 +2117,21 @@ int net_client_init(Monitor *mon, const char *device,
> const char *p)
> #ifdef CONFIG_SLIRP
> if (!strcmp(device, "user")) {
> static const char * const slirp_params[] = {
> - "vlan", "name", "hostname", "restrict", "ip", "tftp", "bootfile",
> - "smb", "redir", "channel", NULL
> + "vlan", "name", "hostname", "restrict", "net", "host",
> + "tftp", "bootfile", "dhcpstart", "dns", "smb", "smbserver",
> + "hostfwd", "guestfwd", NULL
You're renaming "redir" and "channel" here which isn't a big deal since
you've only introduced them in the previous patch, but it would be
better to use the final names in the original patch.
More importantly, though, you've dropped the "ip" parameter which is in
the 0.10.x releases. We can't just drop existing parameters.
By way of meta-comment, some of these patches are much harder to review
than they need to be, because e.g. you're doing lots of cleanups
together with the real changes, or not breaking changes into smaller
chunks.
Cheers,
Mark.
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, (continued)
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, Paul Brook, 2009/05/29
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, Jan Kiszka, 2009/05/29
- Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel, Paul Brook, 2009/05/29
[Qemu-devel] [PATCH 01/11] net: Don't deliver to disabled interfaces in qemu_sendv_packet, Jan Kiszka, 2009/05/08
[Qemu-devel] [PATCH 09/11] slirp: Rework internal configuration, Jan Kiszka, 2009/05/08
[Qemu-devel] [PATCH 10/11] slirp: Rework external configuration interface, Jan Kiszka, 2009/05/08
- Re: [Qemu-devel] [PATCH 10/11] slirp: Rework external configuration interface,
Mark McLoughlin <=
[Qemu-devel] [PATCH 05/11] net: Improve parameter error reporting, Jan Kiszka, 2009/05/08
[Qemu-devel] [PATCH 11/11] slirp: Bind support for host forwarding rules, Jan Kiszka, 2009/05/08
Re: [Qemu-devel] [PATCH 00/11] Networking fixes and slirp enhancements, Anthony Liguori, 2009/05/08