qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp pa


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH 08/11] slirp: Move smb, redir, tftp and bootp parameters and -net channel
Date: Fri, 29 May 2009 16:19:25 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Paul Brook wrote:
>>> +extern char tftp_prefix[PATH_MAX];
>>> +extern char bootp_filename[PATH_MAX];
>> This wouldn't build for me without including limits.h here
> 
> It still won't work. You can't assume PATH_MAX is defined at all.
> 

You are right, one cannot always assume its there, but we already do:

block.c:    char tmp_filename[PATH_MAX];
block.c:    char backing_filename[PATH_MAX];
qemu-char.c:    char pty_name[PATH_MAX];
...

So there must be a way to make all platforms happy qemu builds against.
Otherwise I wouldn't have used it in the first place.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux




reply via email to

[Prev in Thread] Current Thread [Next in Thread]