[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH 17/17] m68k: add cas
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] Re: [PATCH 17/17] m68k: add cas |
Date: |
Sat, 30 May 2009 18:53:17 +0200 |
Le samedi 30 mai 2009 à 15:53 +0200, Andreas Schwab a écrit :
> Laurent Vivier <address@hidden> writes:
>
> > + cmp = DREG(ext, 0);
> > + update = DREG(ext, 6);
> > + tmp = gen_load(s, opsize, addr, 0);
> > + dest = tcg_temp_local_new();
> > + tcg_gen_mov_i32(dest, tmp);
> > +
> > + res = tcg_temp_new();
> > + tcg_gen_sub_i32(res, dest, cmp);
> > + gen_logic_cc(s, res);
> > +
> > + l1 = gen_new_label();
> > + l2 = gen_new_label();
> > +
> > + gen_jmpcc(s, 6 /* !Z */, l1);
> > + gen_store(s, opsize, addr, update);
>
> This has a bug: addr is used around a jump.
>
I agree, thank you.
(I didn't read tcg/README correctly...)
Laurent
- [Qemu-devel] [PATCH 09/17] m68k: add 64bit divide., (continued)
- [Qemu-devel] [PATCH 09/17] m68k: add 64bit divide., Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 10/17] m68k: add 32bit and 64bit multiply, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 11/17] m68k: add word data size for suba/adda, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 12/17] m68k: add fpu, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 13/17] m68k: add "byte", "word" and memory shift, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 14/17] m68k: add "byte", "word" and memory rotate., Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 15/17] m68k: add bitfield_mem, bitfield_reg, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 16/17] m68k: add variable offset/width to bitfield_reg/bitfield_mem, Laurent Vivier, 2009/05/29
- [Qemu-devel] [PATCH 17/17] m68k: add cas, Laurent Vivier, 2009/05/29
- [Qemu-devel] Re: [PATCH 17/17] m68k: add cas, Andreas Schwab, 2009/05/30
- Re: [Qemu-devel] Re: [PATCH 17/17] m68k: add cas,
Laurent Vivier <=
- [Qemu-devel] Re: [PATCH 07/17] m68k: add DBcc instruction., Andreas Schwab, 2009/05/30
- [Qemu-devel] Re: [PATCH 07/17] m68k: add DBcc instruction., Laurent Vivier, 2009/05/30
- Re: [Qemu-devel] [PATCH 04/17] m68k: add missing accessing modes for some instructions., Stuart Brady, 2009/05/30
- Re: [Qemu-devel] [PATCH 04/17] m68k: add missing accessing modes for some instructions., Laurent Vivier, 2009/05/31
Re: [Qemu-devel] [PATCH 00/17] m68k: add partial Motorola 680x0 support, François Revol, 2009/05/30