qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 17/17] m68k: add cas


From: Laurent Vivier
Subject: Re: [Qemu-devel] Re: [PATCH 17/17] m68k: add cas
Date: Sat, 30 May 2009 18:53:17 +0200

Le samedi 30 mai 2009 à 15:53 +0200, Andreas Schwab a écrit :
> Laurent Vivier <address@hidden> writes:
> 
> > +    cmp = DREG(ext, 0);
> > +    update = DREG(ext, 6);
> > +    tmp = gen_load(s, opsize, addr, 0);
> > +    dest = tcg_temp_local_new();
> > +    tcg_gen_mov_i32(dest, tmp);
> > +
> > +    res = tcg_temp_new();
> > +    tcg_gen_sub_i32(res, dest, cmp);
> > +    gen_logic_cc(s, res);
> > +
> > +    l1 = gen_new_label();
> > +    l2 = gen_new_label();
> > +
> > +    gen_jmpcc(s, 6 /* !Z */, l1);
> > +    gen_store(s, opsize, addr, update);
> 
> This has a bug: addr is used around a jump.
> 

I agree, thank you.
(I didn't read tcg/README correctly...)

Laurent





reply via email to

[Prev in Thread] Current Thread [Next in Thread]