Re: [Qemu-devel] Re: [PATCH] qemu: virtio save/load bindings

[Avi Kivity]

Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
> > Implement bindings for virtio save/load. Use them in virtio pci.
> >
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > ---
> >
> > Is anyone working to fill in load/save bindings so that saving virtio
> > devices works? Here's a trivial patch to do this (this one is on top 
> > of my
> > MSI-X patchset).
> > Comments?
> >
> >  hw/virtio-pci.c |   49 
> > ++++++++++++++++++++++++++++++++++++++++++++++++-
> >  hw/virtio.c     |   31 ++++++++++++++-----------------
> >  hw/virtio.h     |    4 ++++
> >  3 files changed, 66 insertions(+), 18 deletions(-)
> >
> >  static void virtio_init_pci(VirtIOPCIProxy *proxy, VirtIODevice *vdev,
> > diff --git a/hw/virtio.c b/hw/virtio.c
> > index 63ffcff..b773dff 100644
> > --- a/hw/virtio.c
> > +++ b/hw/virtio.c
> > @@ -568,9 +568,8 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f)
> >  {
> >      int i;
> >  
> > -    /* FIXME: load/save binding.  */
> > -    //pci_device_save(&vdev->pci_dev, f);
> > -    //msix_save(&vdev->pci_dev, f);
> >   
>
> qdev regressed save/restore?  What else is broken right now from the 
> qdev commit?
>
> I'm beginning to think committing in the state it was in was a 
> mistake.  Paul, can you put together a TODO so that we know all of the 
> things that have regressed so we can get things back into shape?

virtio is still broken.  Anthony, are you planning to commit this patch?

--
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.