Re: [Qemu-devel] [PATCH] remove unused field from pci device.

[Isaku Yamahata]

Hi. As qdev has been introduced, the member PCIBus *bus becomes
also unnecessary because qdev layer tracks bus-device relation.
I already sent a patch to clean it up, I haven't got any reply.
http://lists.gnu.org/archive/html/qemu-devel/2009-06/msg00031.html

If such a patch is acceptable, I'm willing to rebase it and send it out.
Is the patch wanted?

On Mon, Jun 08, 2009 at 03:02:29PM +0300, Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <address@hidden>
> diff --git a/hw/pci.c b/hw/pci.c
> index 0ab5b94..02b335f 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -268,7 +268,7 @@ static PCIDevice *do_pci_register_device(PCIDevice 
> *pci_dev, PCIBus *bus,
>          config_write = pci_default_write_config;
>      pci_dev->config_read = config_read;
>      pci_dev->config_write = config_write;
> -    pci_dev->irq_index = pci_irq_index++;
> +    pci_irq_index++;
>      bus->devices[devfn] = pci_dev;
>      pci_dev->irq = qemu_allocate_irqs(pci_set_irq, pci_dev, 4);
>      return pci_dev;
> diff --git a/hw/pci.h b/hw/pci.h
> index 0405837..fb7b89a 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -154,8 +154,6 @@ struct PCIDevice {
>      PCIConfigReadFunc *config_read;
>      PCIConfigWriteFunc *config_write;
>      PCIUnregisterFunc *unregister;
> -    /* ??? This is a PC-specific hack, and should be removed.  */
> -    int irq_index;
>  
>      /* IRQ objects for the INTA-INTD pins.  */
>      qemu_irq *irq;

-- 
yamahata