qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic
Date: Tue, 09 Jun 2009 17:51:20 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 
On 06/09/09 17:32, Paul Brook wrote:

On Tuesday 09 June 2009, Gerd Hoffmann wrote:

On 06/09/09 17:01, Paul Brook wrote:

+    qdev_init_gpio_out(&sysdev->qdev,&s->parent_irq, 1);

This should be using sysbus_init_irq.

Paul

Patch 3/3 kills that line anyway ...


It's still wrong.


Why doesn't sysbus_init_irq() call qdev_init_gpio_out()?
What is the point in maintaining qemu_irqs in SysBusDevice directly and ignoring the qemu_irqs in DeviceState (aka SysBusDevice.qdev)? 

cheers,
  Gerd
reply via email to
[Prev in Thread] Current Thread [Next in Thread]