Re: [Qemu-devel] [PATCH 1/3] qdev-ify isa pic

[Paul Brook]

On Tuesday 09 June 2009, Gerd Hoffmann wrote:
> On 06/09/09 17:32, Paul Brook wrote:
> > On Tuesday 09 June 2009, Gerd Hoffmann wrote:
> >> On 06/09/09 17:01, Paul Brook wrote:
> >>>> +    qdev_init_gpio_out(&sysdev->qdev,&s->parent_irq, 1);
> >>>
> >>> This should be using sysbus_init_irq.
> >>>
> >>> Paul
> >>
> >> Patch 3/3 kills that line anyway ...
> >
> > It's still wrong.
>
> Why doesn't sysbus_init_irq() call qdev_init_gpio_out()?

Because some devices have both IRQs and GPIO outputs.

Paul