Re: [Qemu-devel] [PATCH] Fix "defined but not used" warning

[Mark McLoughlin]

On Tue, 2009-06-09 at 18:24 -0300, Luiz Capitulino wrote:
> The function qemu_calculate_timeout() is only used when CONFIG_IOTHREAD
> is not defined. When CONFIG_IOTHREAD is defined, we have the following
> warning:
> 
> vl.c:4389: warning: ‘qemu_calculate_timeout’ defined but not used
> 
> This change fixes that by moving the #ifdef/#endif from main_loop()
> into qemu_calculate_timeout(). This encapsulates the logic and allow
> us to use qemu_calculate_timeout() when CONFIG_IOTHREAD is defined
> or not (suggested by Glauber Costa).
> 
> Signed-off-by: Luiz Capitulino <address@hidden>

Looks correct and is a good cleanup too. Moves us closer to being able
to build with --enable-werror always :-)

Reviewed-by: Mark McLoughlin <address@hidden>

Cheers,
Mark.