Re: [Qemu-devel] [PATCH 0/7] virtio-net: Filter cleanup/improvements

[Rusty Russell]

On Wed, 10 Jun 2009 04:55:10 am Mark McLoughlin wrote:
> Hi Alex,
>
> On Fri, 2009-06-05 at 14:46 -0600, Alex Williamson wrote:
> > This series cleans up a few things around packet filtering.  I've
> > probably gone a little overboard on breaking up patches, if we want to
> > avoid bumping the save version_id so much, these could be mostly lumped
> > together.  The main features here are more efficient handling of the
> > filtering between unicast and multicast, better overflow tracking, adding
> > more RX modes, and increasing the size of the filter table and control
> > queue depth.
>
> The whole series looks good to me. Please make sure to send Rusty a
> patch with the VIRTIO_NET_F_CTRL_RX_EXTRA etc. header additions.

Remain unconvinced that it's worth a feature bit.  It'd pretty obscure (hell, 
even multicast is pretty obscure IRL).

Thanks,
Rusty.