[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on confi
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure |
Date: |
Wed, 10 Jun 2009 11:12:55 -0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Jun 10, 2009 at 12:06:27AM +0200, Arnaud Patard wrote:
> Eduardo Habkost <address@hidden> writes:
>
> Hi Eduardo,
>
> > Some glibc versions don't have utimensat() available, but have other xxxat()
> > functions. Make a separated check for utimensat() to make sure we can
> > compile
> > linux-user against some older glibc versions.
>
> Why didn't you take the patches available in this thread
> http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01290.html ?
Because it is not included on the qemu tree.
>
> afaik, they can also be found in maemo's qemu git tree (and sent again
> later to the mailing list)
Why is it not included, if it is a better fix?
>
> [...]
>
> > +#ifdef CONFIG_UTIMENSAT
> > +
> > +#ifdef TARGET_NR_utimensat
> > +static int sys_utimensat(int dirfd, const char *pathname,
> > + const struct timespec times[2], int flags)
> > +{
> > + return (utimensat(dirfd, pathname, times, flags));
> > +}
>
> As you'll see when reading the thread I mentionned, this is broken.
I don't see why it is broken, unless current qemu code is broken too. I
just changed it to use the !CONFIG_ATFILE sys_utimensat() implementation
(that was already present on the code) if glibc doesn't provide
utimensat(). What do you suggest instead?
--
Eduardo
- [Qemu-devel] [PATCH 0/2] linux-user: fix build error against older glibcs, Eduardo Habkost, 2009/06/09
- [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Eduardo Habkost, 2009/06/09
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Rtp, 2009/06/09
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure,
Eduardo Habkost <=
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Rtp, 2009/06/10
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Eduardo Habkost, 2009/06/10
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Riku Voipio, 2009/06/10
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Eduardo Habkost, 2009/06/10
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Riku Voipio, 2009/06/11
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Riku Voipio, 2009/06/10
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Glauber Costa, 2009/06/10
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Rtp, 2009/06/10
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Glauber Costa, 2009/06/10
- Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure, Riku Voipio, 2009/06/10