[Qemu-devel] Re: [PATCH 1/7] vmware_vga: clean up

[Michael S. Tsirkin]

On Tue, Jun 02, 2009 at 03:42:44PM +0900, Isaku Yamahata wrote:
> use NULL instead of 0 for pci_register_device() argument
> for consistency. Any other caller uses NULL.
> 
> Signed-off-by: Isaku Yamahata <address@hidden>

ACK.
Isn't this independend of other patches in the series?
If yes, it's probably better to post them separately.

Acked-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/vmware_vga.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/vmware_vga.c b/hw/vmware_vga.c
> index 79da1ff..ee4f10a 100644
> --- a/hw/vmware_vga.c
> +++ b/hw/vmware_vga.c
> @@ -1217,7 +1217,7 @@ void pci_vmsvga_init(PCIBus *bus)
>      /* Setup PCI configuration */
>      s = (struct pci_vmsvga_state_s *)
>          pci_register_device(bus, "QEMUware SVGA",
> -                sizeof(struct pci_vmsvga_state_s), -1, 0, 0);
> +                sizeof(struct pci_vmsvga_state_s), -1, NULL, NULL);
>      pci_config_set_vendor_id(s->card.config, PCI_VENDOR_ID_VMWARE);
>      pci_config_set_device_id(s->card.config, SVGA_PCI_DEVICE_ID);
>      s->card.config[PCI_COMMAND]              = 0x07;         /* I/O + Memory 
> */
> -- 
> 1.6.0.2

-- 
MST