Re: [Qemu-devel] [PATCH 2/2] check for utimensat() availability on configure

[Eduardo Habkost]

Excerpts from Riku Voipio's message of Wed Jun 10 18:48:26 -0300 2009:
> On Wed, Jun 10, 2009 at 04:10:33PM -0300, Eduardo Habkost wrote:
> > > glibc utimensat is not exactly the syscall, a test on some parameters
> > > has been added. There's code to handle this in the patch I was talking
> > > about.
> 
> > Understood. However, my patch addresses a different issue, that is the
> > case where the host system doesn't have utimensat() available. The point
> > here is to disable the code that uses utimensat() (be it broken or not)
> > on that case.
> 
> > And the first patch is unrelated to that question: it is just a
> > correctness issue to make sure the xxxat() availability matches the
> > situation detected by ./configure (whose test code has #define
> > _ATFILE_SOURCE).
> 
> You mean like this, in the same thread? :)
> 
> http://lists.gnu.org/archive/html/qemu-devel/2009-04/msg01324.html

Yes.  :)

I saw the futimens() part, but I didn't see it was adding a new
configure test including utimensat(), on the first look.


> 
> However your other patch was useful, _ATFILE_SOURCE should be used in 
> syscall.c
> to.
> thanks, applied to the maemo tree.

Cool. :)

Now, we really need to get the fixes from the maemo tree merged on the
master repository. How much have the trees diverged?
-- 
Eduardo