qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] Fix cygwin build and simplify feature dete


From: David Turner
Subject: Re: [Qemu-devel] Re: [PATCH] Fix cygwin build and simplify feature detection in 'configure' script
Date: Thu, 11 Jun 2009 00:29:04 +0200



On Thu, Jun 11, 2009 at 12:17 AM, Filip Navara <address@hidden> wrote:
On Thu, Jun 11, 2009 at 12:09 AM, David Turner<address@hidden> wrote:
[snip]
> Looking at configure through 'git blame' shows that the
> "OS_CFLAGS=-mno-cygwin" line inside it is dated January 2007.
> So I presume that no one is really testing the mainline sources on Windows
> on a regular basis :-(

Wrong presumption. :-) Using MSYS+MinGW here.
 
Mea culpa :-) Thanks for all the answers. As an after-thought, it seems the patch could be
greatly simplified by just forcing the compiler to "gcc -mno-cygwin" if a Cygwin environment
is detected.

I still think that the check_compile() / check_link() helpers are a good ideas, but they are not
directly related to this issue, so they'd better be in a different patch.

I'll send these soon.

Thanks
 

F.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]