Re: [Qemu-devel] [PATCH 2/4] Add device tree machine

[Paul Brook]

On Thursday 11 June 2009, Gerd Hoffmann wrote:
> A few more comments ...
>
> > +static void dt_add_props(DeviceState *dev, void *dt, int offset)
> > +{
>
> Where do device properties come from?  Only the fdt tree?  If so, do we
> need the property lists in the first place?  We could get them directly
> from the fdt tree instead.

The FDT doesn't contain any type information.  My initial implementation 
omitted DevicePropertyList altogether. That ended up fairly messy. Also, when 
we're using the same tree for both qemu and linux the tree probably has 
additional properties we don't care about.

Paul