Re: [Qemu-devel] [PATCH 3/4] qdev: very first cut of scsi bus support.

[Paul Brook]

On Friday 12 June 2009, Gerd Hoffmann wrote:
> +
> +    if (bus) {
> +        d = scsi_create_simple(bus, "scsi-disk");
> +    } else {
> +        /* temporary until usb is qdev-ified */
> +        d = (SCSIDevice *)qemu_mallocz(sizeof(SCSIDevice));

>+static void scsi_disk_initfn(SCSIDevice *dev)
>+{
>+    /* TODO */
>+}

These are both fairly good indicators that this patch is nowhere near ready 
for integration. The whole point of the qdev API is to abstract device 
creation from individual device implementation details. Your implementation 
has the abstraction layers completely backwards.

The I2C code is an example of how a secondary bus should work.

Paul