Re: [Qemu-devel] [PATCH 3/4] qdev: very first cut of scsi bus support.

[Gerd Hoffmann]

On 06/12/09 13:22, Paul Brook wrote:
> On Friday 12 June 2009, Gerd Hoffmann wrote:
> > +
> > +    if (bus) {
> > +        d = scsi_create_simple(bus, "scsi-disk");
> > +    } else {
> > +        /* temporary until usb is qdev-ified */
> > +        d = (SCSIDevice *)qemu_mallocz(sizeof(SCSIDevice));
>
> > +static void scsi_disk_initfn(SCSIDevice *dev)
> > +{
> > +    /* TODO */
> > +}
>
> These are both fairly good indicators that this patch is nowhere near ready
> for integration. The whole point of the qdev API is to abstract device
> creation from individual device implementation details.

I know.  It is tagged "very first cut" for a reason ;)
Just skip it for now if you prefer to wait for something more complete.

> Your implementation
> has the abstraction layers completely backwards.

Yes, but this is how it works in qemu today.
Changing that without breaking stuff isn't that easy though.
Guess I'll first have a look at usb anyway, so I can make sure 
usb-storage is covered too.

cheers,
  Gerd