[Qemu-devel] Re: [Qemu-commits] [COMMIT 95bed64] Fix a warning: uint_fast8_t is not 8 bits onOpenBSD/Sparc64

[Paul Brook]

> >  > +        asid = env->tlb->mmu.r4k.tlb[i].ASID;
> >  > +        qemu_put_8s(f, &asid);
> >
> >  Wouldn't it be simpler to just use qemu_put_byte?
>
> uint_fast8_t equals uint32_t on OpenBSD/Sparc64. It's also big endian,
> so qemu_put_byte(f, &env->tlb->mmu.r4k.tlb[i].ASID) writes the MSB
> (==0).

Not even close. qemu_put_byte works by value, not by reference. i.e. you want
  qemu_put_byte(f, env->tlb->mmu.r4k.tlb[i].ASID);

Paul