qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Register uhci_reset() callback.


From: Paul Brook
Subject: Re: [Qemu-devel] Register uhci_reset() callback.
Date: Mon, 15 Jun 2009 18:56:26 +0100
User-agent: KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; )

> May be, but in this case after previous patch to reset interrupt level
> for each device at PCI bridge level was rejected on the premise that
> device should lower its own irq line on reset and since patches started
> flowing in to do just that, I did not expect that eloquent explanation
> would be needed for such trivial and obviously correct change.

This argument makes no sense. The fact that you'd recently submitted very 
similar looking patches which either got rejected or need modification is a 
good argument for providing an explanation. How else are we supposed to know 
that you're not just making the same mistake again?

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]