qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCHv4 01/13] qemu: make default_write_config use mas


From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCHv4 01/13] qemu: make default_write_config use mask table
Date: Tue, 16 Jun 2009 15:40:13 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Michael S. Tsirkin wrote:
Change much of hw/pci to use symbolic constants and a table-driven
design: add a mask table with writable bits set and readonly bits unset.
Detect change by comparing original and new registers.

This makes it easy to support capabilities where read-only/writeable
bit layout differs between devices, depending on capabilities present.

As a result, writing a single byte in BAR registers now works as
it should. Writing to upper limit registers in the bridge
also works as it should. Code is also shorter.

Signed-off-by: Michael S. Tsirkin <address@hidden>
This series introduces warning (virtio_load decl/def does not match).

--
Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]