qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/3] Call piix3_reset() on system reset.


From: Gleb Natapov
Subject: Re: [Qemu-devel] [PATCH 2/3] Call piix3_reset() on system reset.
Date: Thu, 18 Jun 2009 09:02:56 +0300

On Wed, Jun 17, 2009 at 08:10:23PM +0300, Blue Swirl wrote:
> On 6/17/09, Gleb Natapov <address@hidden> wrote:
> > Also zero pci_irq_levels on reset to avoid stuck irq after reset.
> >
> >  Signed-off-by: Gleb Natapov <address@hidden>
> >  Signed-off-by: Yaniv Kamay <address@hidden>
> 
> Thanks, applied.
Thanks, but without 1/3 reset is still buggy. Look at hw/pci.c:pci_set_irq()
If pci_dev->irq_state[irq_num] == 1 at reset time it will stay 1 after
reset too. When device will try to race IRQ line after reset it will
fail to do so. And if bus->irq_count[] is not zeroed you have another
set of problems. If you don't like that pci_bus_reset() reset per device
state (why?) it is possible to create pci_device_reset(), but then we
will have to fix 25 devices to call it.  Complication for no good
reason. IMHO pci_device_save/load should be handled in hw/pci.c too.
What are the disadvantages?
 
--
                        Gleb.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]