Re: [Qemu-devel] [PATCH v4] avoid compilation warning/errors on up to date

[Jean-Christophe Dubois]

Le jeudi 18 juin 2009 22:33:03 Anthony Liguori, vous avez écrit :
> Luiz Capitulino wrote:
> > On Thu, 18 Jun 2009 01:16:37 +0200
> >
> > "Jean-Christophe Dubois" <address@hidden> wrote:
> >> And whatever I have added is a lot more robust than what was before.
> >> Once again, please just show me where my patch is incorrect and I
> >> will fix it.
> >
> >  I really missed this v4, sorry for that and thanks for letting me know.
> >
> >  I think the first step is to do one logical change at a time. You
> > could, for example do:
> >
> >  1. Add qemu_read() and qemu_write()
>
> We already have these in various places.  The problem is, we often want
> different semantics.  We don't always want to retry partial results
> (like for live migration).  We need a more rationalized approach to this.

Anthony, I am not sure to understand what you mean here. Are you against the 
qemu_read/qemu_write approach? Are you hinting that your preference is that 
each and every read/write call handles its error case in its own local way?