|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC |
| Date: | Sun, 21 Jun 2009 12:01:59 +0300 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2 |
On 06/20/2009 11:46 PM, Anthony Liguori wrote:
Avi Kivity wrote:On 06/20/2009 05:31 PM, Anthony Liguori wrote:Please include a Signed-off-by line and use C-style comments instead of C++ style comments. Otherwise, looks good.What do we have against C++ style comments?Just consistency: address@hidden:~/git/qemu$ grep '//' *.c | wc -l 163 address@hidden:~/git/qemu$ grep '/\*' *.c | wc -l 5642
Well, consistency trumps convenience.
Nothing personal. I think the kernel has a policy of C89 comments only.
This isn't the kernel, we have our own coding style. But if we don't want C++ comments, that's fine.
-- error compiling committee.c: too many arguments to function
| [Prev in Thread] | Current Thread | [Next in Thread] |